Open
Conversation
auberonedu
reviewed
Feb 18, 2025
auberonedu
left a comment
auberonedu
left a comment
There was a problem hiding this comment.
Looks like you didn't get a chance to fully finish, but nice job with the tokenizer!
Comment on lines
+46
to
+47
| char last = word.charAt(word.length()-1); | ||
| if(last != '.'){ |
There was a problem hiding this comment.
This works well! You can also use endsWith here
Comment on lines
+38
to
+41
| String line = scanner.nextLine(); | ||
| // makes an array from the line using spaces gets rid of extra spaces with + | ||
| // source for \\s vs \\s+ : https://stackoverflow.com/a/15625711 | ||
| String[] list = line.split("\\s+"); |
There was a problem hiding this comment.
Thanks for citing your source! You can also rely on scanner.next which handles the whitespace for you automatically
Comment on lines
+22
to
+29
| @Test | ||
| void testTokenizeWithMultipleSpaces() { | ||
| LowercaseSentenceTokenizer tokenizer = new LowercaseSentenceTokenizer(); | ||
| Scanner scanner = new Scanner("hello hi hi hi hello hello"); | ||
| List<String> tokens = tokenizer.tokenize(scanner); | ||
|
|
||
| assertEquals(List.of("hello", "hi", "hi", "hi", "hello", "hello"), tokens); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was as much as I could get done within the timeframe.